Choose account popup

[evertonfraga]

Here the user will have the ability to choose among her/his accounts from a modal to use on the current Dapp. The idea is to provide more information about what's being shared.

this is a work in progress.

[alexvandesande]

This branch needs merging. What's the update on this progress?

[hiddentao]

What's the status of this?

[evertonfraga]

@hiddentao still some progress to make. Lacks pin to sidebar checkbox, and some webview interactions.

[alexvandesande]

Looking good! But some issues I've noticed testing it:

• When you click on the pop-up on an app already added, it should start with the selected accounts already selected
• It's not loading the favicon, always showing the globe icon, nor the url or the name of the app
• When you select "create new account" it should at minimum return with that one selected on the next screen.
• It's not removing the tab when you click X but this is a bug you're already aware

[evertonfraga]

After @hiddentao's sync fix, I've added the pin/unpin Tab ability. Now ready for testing.

[evertonfraga]

@luclu Including #554 here.

[alexvandesande]

merged with #1023

[miderose]

Hi, I'm using mist 0.8.7;
It seems the mist.requestAccount does not execute the callback...

this function:

    mist.requestAccount(
        function (e, account) {
            console.log("done");
            console.log(e, account);
        }
    );

shows the accounts modal, but never execute the callback after I choose/create an account.

Is this feature released or it's in a developing state yet?

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.