Skip to content
This repository has been archived by the owner on May 17, 2022. It is now read-only.

readthedocs.org build fix #434

Merged
merged 2 commits into from
Mar 21, 2018
Merged

readthedocs.org build fix #434

merged 2 commits into from
Mar 21, 2018

Conversation

sampullman
Copy link
Contributor

This is a potential fix for #389 which appears to be caused by this Sphinx issue. I can't verify it without running the actual build on Read the Docs, but the problem should go away if the build uses a new Sphinx version.

Note that wiping the environment on readthedocs.org may be required.

The second commit fixes a bunch of Pygments lexer errors that showed up after the upgrade.

Copy link
Member

@pirapira pirapira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

A remaining task is to see how to detect this in Travis.

@pirapira pirapira merged commit 905bd28 into ethereum:master Mar 21, 2018
@sampullman sampullman deleted the rtd-build-fix branch March 21, 2018 17:47
@sampullman
Copy link
Contributor Author

@paulvi I was not aware that those files were completely off limits. Updating Sphinx, which is required for the Read the Docs build, introduces two build errors in the archive. If the old docs cannot be modified, the solution is probably to remove them from the build process (it's probably better to do this regardless).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants