Abstract gas v3 #427
Merged
Abstract gas v3 #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00b3541 to
7a05327
Compare
d-xo
reviewed
Dec 5, 2023
cli/cli.hs
Outdated
| @@ -203,7 +203,7 @@ main = do | |||
| } } | |||
| case cmd of | |||
| Version {} ->putStrLn getFullVersion | |||
| Symbolic {} -> do | |||
| Symbolic' {} -> do | |||
There was a problem hiding this comment.
This breaks the cli interface and turns hevm symbolic into hevm symbolic'. We should keep this as is
d-xo
reviewed
Dec 5, 2023
src/EVM.hs
Outdated
| freezeMemory memory = | ||
| ConcreteBuf . BS.pack . VUnboxed.toList <$> VUnboxed.freeze memory | ||
|
|
||
|
|
||
| class VMOps (t :: VMType) where |
There was a problem hiding this comment.
It would be nice to pull this out into it's own section at the top of the file (or maybe into Types.hs?)
There was a problem hiding this comment.
moved to Types, instances have to stay in EVM otherwise it would cause cyclic dependency
d-xo
reviewed
Dec 5, 2023
|
@d-xo it's ready |
|
Merged. Thanks <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another try for abstract gas (see #403, #404).
I introduced two types of VMs that we can specialize execution for:
VM SymbolicandVM Concrete. The behavior can be specialized in instances ofVMOpsclass and data structures with type families similar toGas (t :: VMType)introduced here. Thanks to-fspecialize-aggressively -fexpose-all-unfoldingsthis version is only slightly (~2%) slower thanmainas all theVMOps-dependent functions should be picked at compile time. This opens a whole world of possibilities for optimizing the concrete version of the VM without introducing too many changes.For instance, having
branchspecialized tobranch (Lit cond) continue = continue (cond > 0)in concrete VM speeds up ethereum-tests over 10% which puts way ahead compared to the current main. I didn't include further optimizations to limit the scope of this PR to gas.Checklist