Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build, internal/build: misc improvements #3229

Merged
merged 4 commits into from
Nov 3, 2016
Merged

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Nov 3, 2016

This PR makes small adjustments to automated builds:

  • darwin/386 builds don't make sense because macOS only runs on 64 bit machines.
  • darwin builds should be distributed as tar.gz archives
  • some scripts still referred to the godep workspace
  • zip archives were not compressed. Adding compression shrinks the geth-only archive
    from ~20MB to ~6MB.

@mention-bot
Copy link

@fjl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @karalabe, @tgerring and @obscuren to be potential reviewers.

- enable compression for zip files
- don't write half-complete archives
@fjl fjl added the review label Nov 3, 2016
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit ed2bc7f into ethereum:develop Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants