Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/bn256: fix MulScalar #30974

Merged
merged 1 commit into from
Jan 2, 2025
Merged

crypto/bn256: fix MulScalar #30974

merged 1 commit into from
Jan 2, 2025

Conversation

gitglorythegreat
Copy link
Contributor

The a parameter should be used in the MulScalar function. The upstream cloudflare and google repos have already merged fixes.

Reference:

MariusVanDerWijden
MariusVanDerWijden approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fortunately it is only ever used in our code base with a == e

@fjl fjl merged commit 0feb999 into ethereum:master Jan 2, 2025
2 checks passed
@fjl fjl added this to the 1.14.13 milestone Jan 2, 2025
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 3, 2025
@gitglorythegreat @gzliudan
crypto/bn256: fix MulScalar (ethereum#30974)
9e5bbae 
The `a` parameter should be used in the `MulScalar` function. The
upstream cloudflare and google repos have already merged fixes.

Reference:
*
https://cs.opensource.google/go/x/crypto/+/8d7daa0c54b357f3071e11eaef7efc4e19a417e2
* cloudflare/bn256#33
@gzliudan gzliudan mentioned this pull request Jan 3, 2025
Merged
19 tasks
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 4, 2025
@gitglorythegreat @gzliudan
crypto/bn256: fix MulScalar (ethereum#30974)
9ca3d10 
The `a` parameter should be used in the `MulScalar` function. The
upstream cloudflare and google repos have already merged fixes.

Reference:
*
https://cs.opensource.google/go/x/crypto/+/8d7daa0c54b357f3071e11eaef7efc4e19a417e2
* cloudflare/bn256#33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@jwasinger jwasinger Awaiting requested review from jwasinger jwasinger is a code owner

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@fjl fjl Awaiting requested review from fjl fjl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.13
Development

Successfully merging this pull request may close these issues.
4 participants
@gitglorythegreat @rjl493456442 @MariusVanDerWijden @fjl