-
Notifications
You must be signed in to change notification settings - Fork 20.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common/math: rename variable name int
to in
#29890
Conversation
|
Ah, sorry for it. But anyway, using built-in identifier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could agree with replacing with with n
, which is used across Go. But in
seems arbitrary.
@karalabe Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* chore: rename variable name `int` to `in` * chore: rename variable name `int` to `n`
* chore: rename variable name `int` to `in` * chore: rename variable name `int` to `n`
* chore: rename variable name `int` to `in` * chore: rename variable name `int` to `n`
* chore: rename variable name `int` to `in` * chore: rename variable name `int` to `n`
* chore: rename variable name `int` to `in` * chore: rename variable name `int` to `n`
* chore: rename variable name `int` to `in` * chore: rename variable name `int` to `n`
It's odd to use the keyword
int
as variable name, I think it's better to usein