Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/math: rename variable name int to in #29890

Merged
merged 2 commits into from
May 31, 2024

Conversation

tianyeyouyou
Copy link
Contributor

It's odd to use the keyword int as variable name, I think it's better to use in

@fjl
Copy link
Contributor

fjl commented May 30, 2024

int is not a keyword, it's just a built-in identifier, and can be shadowed.

@tianyeyouyou
Copy link
Contributor Author

Ah, sorry for it.

But anyway, using built-in identifier int is odd too...

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could agree with replacing with with n, which is used across Go. But in seems arbitrary.

@tianyeyouyou
Copy link
Contributor Author

@karalabe Done

@tianyeyouyou tianyeyouyou requested a review from karalabe May 31, 2024 06:31
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.14.4 milestone May 31, 2024
@karalabe karalabe merged commit bdc62f9 into ethereum:master May 31, 2024
2 of 3 checks passed
@tianyeyouyou tianyeyouyou deleted the chore/var-name branch May 31, 2024 07:58
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
* chore: rename variable name `int` to `in`

* chore: rename variable name `int` to `n`
stwiname pushed a commit to subquery/data-node-go-ethereum that referenced this pull request Sep 9, 2024
* chore: rename variable name `int` to `in`

* chore: rename variable name `int` to `n`
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Dec 19, 2024
* chore: rename variable name `int` to `in`

* chore: rename variable name `int` to `n`
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Dec 21, 2024
* chore: rename variable name `int` to `in`

* chore: rename variable name `int` to `n`
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Dec 26, 2024
* chore: rename variable name `int` to `in`

* chore: rename variable name `int` to `n`
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Dec 28, 2024
* chore: rename variable name `int` to `in`

* chore: rename variable name `int` to `n`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants