p2p: use slices package for sorting #27494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Jun 16, 2023
fjl
requested changes
Jun 16, 2023
| func (cs capsByNameAndVersion) Less(i, j int) bool { | ||
| return cs[i].Name < cs[j].Name || (cs[i].Name == cs[j].Name && cs[i].Version < cs[j].Version) | ||
| func capLessFunc(a, b Cap) bool { | ||
| return a.Name < b.Name || (a.Name == b.Name && a.Version < b.Version) | ||
| } |
There was a problem hiding this comment.
I would prefer to have a method
func (cap Cap) Less(other Cap) bool { ... }You can then use it like this:
slices.SortFunc(caps, Cap.Less)
There was a problem hiding this comment.
It'd actually have to look like this:
slices.SortFunc(caps, func(a, b Cap) bool {
return a.Less(b)
})and I felt this was less attractive but up to you
There was a problem hiding this comment.
It'd actually have to look like this:
Incorrect. Proof: https://go.dev/play/p/cE5HK4dAyl8
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
Co-authored-by: Felix Lange <fjl@twurst.com>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 9bcadfb.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 9bcadfb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #27474