all: remove ethash pow, only retain shims needed for consensus and tests #27178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You also have some residue in the lower parts of README.md about running a private miner. |
MariusVanDerWijden
approved these changes
May 3, 2023
| @@ -208,10 +208,6 @@ func newTestWorker(t *testing.T, chainConfig *params.ChainConfig, engine consens | |||
| return w, backend | |||
| } | |||
|
|
|||
| func TestGenerateBlockAndImportEthash(t *testing.T) { | |||
| testGenerateBlockAndImport(t, false) | |||
There was a problem hiding this comment.
Shouldn't we also remove the functionality in the test? L 229ff
This was referenced May 3, 2023
3 tasks
|
Does this mean |
|
It can still sync from genesis, but since the PoW part is frozen and can
never change any more, verifying the PoW fields are skipped.
…On Tue, 6 Jun 2023 at 04:25, zhiqiangxu ***@***.***> wrote:
Does this mean go-ethereum doesn't support sync from genesis any more?
—
Reply to this email directly, view it on GitHub
<#27178 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA7UGM7GN75SICGMU7IR5DXJ2BHHANCNFSM6AAAAAAXN3NALU>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
…sts (ethereum#27178) * all: remove ethash pow, only retain shims needed for consensus and tests * all: thank you linter * all: disallow launching Geth in legacy PoW mode * cmd/env/internal/t8ntool: remove dangling ethash flag
holiman
added a commit
that referenced
this pull request
Jul 6, 2023
Back before #27178 , we spun up a number of ethash verifiers to verify headers. So we also had tests to ensure that we were indeed able to abort verification even if we had multiple workers running. With PR #27178, we removed the parallelism in verification, and these tests are now failing, since we now just sequentially fire away the results as fast as possible on one routine. This change removes the (sometimes failing) tests
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…sts (ethereum#27178) * all: remove ethash pow, only retain shims needed for consensus and tests * all: thank you linter * all: disallow launching Geth in legacy PoW mode * cmd/env/internal/t8ntool: remove dangling ethash flag
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
Back before ethereum#27178 , we spun up a number of ethash verifiers to verify headers. So we also had tests to ensure that we were indeed able to abort verification even if we had multiple workers running. With PR ethereum#27178, we removed the parallelism in verification, and these tests are now failing, since we now just sequentially fire away the results as fast as possible on one routine. This change removes the (sometimes failing) tests
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…s and tests (ethereum#27178)" This reverts commit 3eb5306.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…s and tests (ethereum#27178)" This reverts commit 3eb5306.
lgray
added a commit
to lgray/chainindex
that referenced
this pull request
Dec 29, 2023
…s and tests (ethereum#27178)" This reverts commit dde2da0.
lgray
added a commit
to lgray/chainindex
that referenced
this pull request
Dec 31, 2023
…s and tests (ethereum#27178)" This reverts commit dde2da0.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove PoW 😅
The PR also removes the ethash related flags, configs and API methods in a non-backwards compatible way. There is quite a bit of stuff that we'd need to keep dangling in the code to avoid "that one user" not having upgrade issues. As we're right after a fork, there's no immediate urgency to update, might as well bork things now.
Probably the PR should add some vocal failure modes for running Geth in non-beacon-ethash mode.Done!We also need a followup PR to move the consensus things into a
legacyorhistoricalpackage (or directly into thebeaconpackage) and to rewrite the tests to use some beacon shims instead of the current skeletons inethash. Then we can be free. That needs a bit of refactor so I wanted to start by mass removes and then review the refactors separately more easily.