Strip extraneous carriage return from end of entered password #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
|
👍 |
| @@ -92,6 +92,7 @@ func PromptPassword(prompt string, warnTerm bool) (string, error) { | |||
| } | |||
| fmt.Print(prompt) | |||
| input, err := bufio.NewReader(os.Stdin).ReadString('\n') | |||
| input = strings.TrimRight(input, "\r\n") | |||
There was a problem hiding this comment.
The \r is weird. Why is it required?
There was a problem hiding this comment.
I found this to be necessary for Windows.
|
👍 |
|
@hiddentao please fix your commit message like: |
90aa0a1 to
6f30034
Compare
|
@obscuren commit msg updated. |
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a repeat of #2369 but against the
developbranch.The fix has been tested to work on OS X, Ubuntu and Windows.