Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/utils: add workaround for FreeBSD statfs quirk #22310

Merged
merged 3 commits into from
Feb 15, 2021

Conversation

gballet
Copy link
Member

@gballet gballet commented Feb 11, 2021

Workaround to get geth to build on FreeBSD. Fixes #22309.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman
Copy link
Contributor

holiman commented Feb 11, 2021

Hah, now you need to convince the linter about freebsd:

cmd/utils/diskusage.go:40:15: unnecessary conversion (unconvert)
	return uint64(bavail) * uint64(stat.Bsize), nil

@holiman
Copy link
Contributor

holiman commented Feb 11, 2021

other than disabling the linter in the ci config, isn't there some way to make a comment that the linter understands? Something like //nolint:unconvert

That makes the fix work regardless of CI config (like, when you run it locally)

@gballet gballet force-pushed the freebsd-fix-fstat-build branch from eeeddab to 5f90137 Compare February 15, 2021 09:29
@holiman holiman merged commit 08c878a into ethereum:master Feb 15, 2021
@holiman holiman added this to the 1.10.0 milestone Feb 15, 2021
filipescuc pushed a commit to EthereumGenesys/go-ethereum that referenced this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

freebsd build is broken
2 participants