Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphql: change receipt status to decimal instead of hex #22187

Merged
merged 3 commits into from
Jan 25, 2021
Merged

graphql: change receipt status to decimal instead of hex #22187

merged 3 commits into from
Jan 25, 2021

Conversation

renaynay
Copy link
Contributor

This PR fixes the Status field to be decimal instead of a hex string, as called for by the spec.

@renaynay renaynay requested a review from gballet as a code owner January 18, 2021 13:37
@renaynay
Copy link
Contributor Author

Is Long still okay or should we go with Int instead? #20040 (comment)

holiman
holiman reviewed Jan 18, 2021
View reviewed changes
graphql/graphql.go Outdated Show resolved Hide resolved
renaynay and others added 2 commits January 18, 2021 14:51
@renaynay @holiman
no explicit cast
08f0614 
Co-authored-by: Martin Holst Swende <martin@swende.se>
@renaynay
remove other TODO and type cast
c8d9b31
holiman
holiman approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl changed the title graphql: status should be decimal instead of hex string graphql: change receipt status to decimal instead of hex Jan 25, 2021
@fjl fjl merged commit c0862f4 into ethereum:master Jan 25, 2021
@fjl fjl added this to the 1.10.0 milestone Jan 25, 2021
@renaynay renaynay deleted the graphql_fix_statusReturnVal branch January 25, 2021 11:34
bulgakovk pushed a commit to bulgakovk/go-ethereum that referenced this pull request Jan 26, 2021
@renaynay @holiman @bulgakovk
graphql: change receipt status to decimal instead of hex (ethereum#22187
45442d3 
)

This PR fixes the receipt status field to be decimal instead of a hex string,
as called for by the spec.

Co-authored-by: Martin Holst Swende <martin@swende.se>
@quorumbot quorumbot mentioned this pull request Sep 3, 2021
Merged
9 tasks
@baptiste-b-pegasys baptiste-b-pegasys mentioned this pull request Sep 3, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@gballet gballet Awaiting requested review from gballet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@renaynay @holiman @fjl