internal/ethapi: print tx details when submitting #22170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ryanschneider -- you guys would get a lot of data in the logs, would it be a problem? |
c0d4872 to
8b318ff
Compare
|
@holiman I think it'd be ok for us, it's not that much more logging/load than just logging the hash and I agree that it helps a lot with debugging. |
fjl
reviewed
Jan 21, 2021
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open for discussion, not sure if we should add this or not.
This PR adds some more infos to the logs when submitting a tx. The idea being that the current logs are enough to find the tx infos if it gets listed in some block explorer, but if it does not (e.g. lost tx or nonce gap), there's no way to see what was being submitted. This can cause problems debugging nonce issues and/or resubmitting lost txs manually.