Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/fuzzers/abi: better test generation #22158

Merged
merged 3 commits into from
Jan 18, 2021

Conversation

MariusVanDerWijden
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden commented Jan 11, 2021

Fixes the fuzzers

2021/01/11 11:12:10 workers: 16, corpus: 212 (24s ago), crashers: 0, restarts: 1/9679, execs: 7085542 (12365/sec), cover: 1996, uptime: 9m33s
2021/01/11 11:12:13 workers: 16, corpus: 212 (27s ago), crashers: 0, restarts: 1/9663, execs: 7121919 (12364/sec), cover: 1996, uptime: 9m36s
2021/01/11 11:12:16 workers: 16, corpus: 212 (30s ago), crashers: 0, restarts: 1/9699, execs: 7158058 (12363/sec), cover: 1996, uptime: 9m39s
2021/01/11 11:12:19 workers: 16, corpus: 212 (33s ago), crashers: 0, restarts: 1/9669, execs: 7194322 (12361/sec), cover: 1996, uptime: 9m42s

It decreases a bit the ability of the fuzzers to test everything, since the Pack(Unpack(in)) == in test was removed. However this test would often fail if the ABI only had a single argument, eg. 0x123...890 would be unpacked to 0x0000...0090 if the ABI only specifies a single uint8 argument, therefore the packing step could never recreate in.

The PR also reenables the abi fuzzer for oss-fuzz (it was disabled since it created so many errors)
@holiman If you think it is to early to put it on oss-fuzz we can also drop the last commit ed4865f

@MariusVanDerWijden MariusVanDerWijden marked this pull request as ready for review January 11, 2021 10:18
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll notice if it starts failing on oss-fuzz, it's not a biggie to fix it later if so

@holiman holiman merged commit 3981822 into ethereum:master Jan 18, 2021
bulgakovk pushed a commit to bulgakovk/go-ethereum that referenced this pull request Jan 26, 2021
* tests/fuzzers/abi: better test generation

* tests/fuzzers/abi: fixed packing issue

* oss-fuzz: enable abi fuzzer
@MariusVanDerWijden MariusVanDerWijden deleted the abifuzzer branch November 30, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants