les: remove transaction propagation limits #22125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsfelfoldi
approved these changes
Jan 7, 2021
DGKSK8LIFE
approved these changes
Jan 7, 2021
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the restriction in the transaction propagation.
Previously, the transaction will only be sent to the specific peer for one time. This approach is not robust enough, espeically when the peerset is small. Round-of-robin is enough for distributing the transaction to the network.
In this PR, the propagation logic is simplied a lot. Whenever the light client tries to broadcast transactions, it just picks a few peers with Round-of-robin algo.