-
Notifications
You must be signed in to change notification settings - Fork 20.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abi/bind: fix error-handling in generated wrappers for functions returning structs #22005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorwstein
requested review from
gballet and
MariusVanDerWijden
as code owners
December 11, 2020 17:53
MariusVanDerWijden
approved these changes
Dec 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for noticing, and adding a test 👍
@MariusVanDerWijden thanks for the quick review. The build failure looks like a flake - would you be able to re-run? Don't think I have permissions to do that. |
restarted |
holiman
changed the title
Fix err handling in generated wrappers for functions returning structs
abi/bind: fix error-handling in generated wrappers for functions returning structs
Dec 12, 2020
Thanks! |
9 tasks
9 tasks
This was referenced Sep 23, 2022
9 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 7, 2025
…rning structs (ethereum#22005) Fixes the template used when generating code, which in some scenarios would lead to panic instead of returning an error.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 7, 2025
…rning structs (ethereum#22005) Fixes the template used when generating code, which in some scenarios would lead to panic instead of returning an error.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 9, 2025
…rning structs (ethereum#22005) Fixes the template used when generating code, which in some scenarios would lead to panic instead of returning an error.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
…rning structs (ethereum#22005) Fixes the template used when generating code, which in some scenarios would lead to panic instead of returning an error.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
…rning structs (ethereum#22005) Fixes the template used when generating code, which in some scenarios would lead to panic instead of returning an error.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
…rning structs (ethereum#22005) Fixes the template used when generating code, which in some scenarios would lead to panic instead of returning an error.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
…rning structs (ethereum#22005) Fixes the template used when generating code, which in some scenarios would lead to panic instead of returning an error.
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 14, 2025
…rning structs (ethereum#22005) Fixes the template used when generating code, which in some scenarios would lead to panic instead of returning an error.
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 16, 2025
…rning structs (ethereum#22005) Fixes the template used when generating code, which in some scenarios would lead to panic instead of returning an error.
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 17, 2025
…rning structs (ethereum#22005) Fixes the template used when generating code, which in some scenarios would lead to panic instead of returning an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the template was changed which ended up producing code like:
which will panic instead of returning an error if the contract doesn't exist. I moved the error handling up before the indexing to avoid that (analogous to how non-struct responses are handled)