-
Notifications
You must be signed in to change notification settings - Fork 20.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile, README: remove evm target, add puppeth to table #14886
Conversation
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
Adding puppeth command to top-level Makefile
d50de8d
to
3d1db4e
Compare
Not sure I want this. You can always just run |
If it's a command now available in cmd, should probably be treated same as other commands and updated in README, no? |
cmd/puppeth is a command. But not all commands need a dedicated Makefile target. IMHO we have too many targets already. I would approve a PR that deletes the swarm and evm targets for example. |
Sounds good, thanks. Updated. PTAL |
FYI the Swarm team currently recommends |
I think @fjl suggested using |
@lmars I was waiting for your feedback. Let's remove "evm" target but keep "swarm" for now. |
Remove evm, swarm from top-level Makefile (consistency with puppeth) and add puppeth to README