Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): use local eels #997

Merged
merged 3 commits into from
Dec 5, 2024
Merged

fix(ci): use local eels #997

merged 3 commits into from
Dec 5, 2024

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Dec 5, 2024 •
edited
Loading

🗒️ Description

This PR proposes an alternative to #995 to fix the current CI fails running the framework tests:

  • tox_verify checks out ethereum/execution-specs.
  • Added .github/configs/eels_resolutions.json which resolves forks to this local clone.
  • tox_verify sets the EELS_RESOLUTIONS_FILE env var to <WORKSPACE>/.github/configs/eels_resolutions.json
  • tox.ini uses the EELS_RESOLUTIONS_FILE env var ((only) in the framework testenv) if it has been set.

Improvements:

  • It'd be nice to provide the ref as a config and use it for local, user runs, via the resolver too. If this is the preferred approach, I would do this in a follow-up PR.

Verifying the EELS resolution file

image

🔗 Related Issues

#995.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@danceratopz danceratopz added type:bug Something isn't working scope:ci Scope: Continuous Integration scope:tooling Scope: Python tools (uv, ruff, tox,...) scope:fill Scope: fill command labels Dec 5, 2024
@danceratopz danceratopz self-assigned this Dec 5, 2024
@danceratopz danceratopz mentioned this pull request Dec 5, 2024
Closed
8 tasks
marioevz
marioevz approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit 2c5c008 into main Dec 5, 2024
5 checks passed
@marioevz marioevz deleted the fix/ci/use-local-eels branch December 5, 2024 12:54
This was referenced Dec 5, 2024
Open
Open
codeofcarson pushed a commit to codeofcarson/execution-spec-tests that referenced this pull request Jan 24, 2025
@danceratopz @codeofcarson
fix(ci): use local eels (ethereum#997)
aa6ce46 
* chore(ci): remove checkout submodule init for eest

EEST doesn't have any submodules.

* chore(ci): use a local eels checkout for framework tests

* docs: update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees

@danceratopz danceratopz

Labels
scope:ci Scope: Continuous Integration scope:fill Scope: fill command scope:tooling Scope: Python tools (uv, ruff, tox,...) type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danceratopz @marioevz