Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests): EOF - EIP-3540: validation of opcodes #932

Merged
merged 1 commit into from
Nov 7, 2024
Merged

new(tests): EOF - EIP-3540: validation of opcodes #932

merged 1 commit into from
Nov 7, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Oct 31, 2024 •
edited
Loading

🗒️ Description

Add missing opcode tests:

  • invalid opcode placed after a terminating instruction,
  • opcodes with truncated immediate bytes.

Mark rest of the "opcode tests" as done by providing links to tests.

✅ Checklist

@chfast chfast added scope:tests Scope: Changes EL client test cases in `./tests` type:test Type: Add/refactor fw unit tests; no fw or el client test case changes labels Oct 31, 2024
pdobacz
pdobacz approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can go as is, but I had a couple of comments/ideas

@marioevz
Copy link
Member

marioevz commented Nov 1, 2024

Created ipsilon#4 with a suggestion, let me know if the changes look good to you.

@chfast chfast force-pushed the eof/migrate_opcode_validation branch from 3d305f0 to 98d3b74 Compare November 5, 2024 13:33
@chfast chfast force-pushed the eof/migrate_opcode_validation branch 2 times, most recently from 463438d to 2ebbe43 Compare November 7, 2024 14:48
@chfast @marioevz @danceratopz
new(tests): EOF validation of opcodes
7495ca6 
Add missing opcode tests:
- invalid opcode placed after a terminating instruction,
- opcodes with truncated immediate bytes.

Mark rest of the "opcode tests" as done by providing links to tests.

Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: danceratopz <danceratopz@gmail.com>
@chfast chfast force-pushed the eof/migrate_opcode_validation branch from 25f03df to 7495ca6 Compare November 7, 2024 16:10
@marioevz marioevz changed the title new(tests): EOF validation of opcodes new(tests): EOF - EIP-3540: validation of opcodes Nov 7, 2024
@marioevz marioevz merged commit fe37ca2 into ethereum:main Nov 7, 2024
3 checks passed
@marioevz marioevz deleted the eof/migrate_opcode_validation branch November 7, 2024 16:31
@pdobacz pdobacz mentioned this pull request Nov 20, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdobacz pdobacz pdobacz approved these changes

@marioevz marioevz marioevz left review comments

@winsvega winsvega winsvega approved these changes

@danceratopz danceratopz Awaiting requested review from danceratopz

@shemnon shemnon Awaiting requested review from shemnon

Assignees
No one assigned
Labels
scope:tests Scope: Changes EL client test cases in `./tests` type:test Type: Add/refactor fw unit tests; no fw or el client test case changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chfast @marioevz @shemnon @winsvega @pdobacz @danceratopz