Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF - EIP-4200 EIP-6206 RJUMPI with JUMPF #928

Merged
merged 7 commits into from
Nov 1, 2024

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Oct 30, 2024

πŸ—’οΈ Description

Continues #833 with some tests with JUMPF to non-returning functions. I got stuck on JUMPF to returning functions so I'm making this little step first.

πŸ”— Related Issues

na

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@pdobacz pdobacz requested review from marioevz and shemnon October 31, 2024 10:35
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@marioevz
Copy link
Member

marioevz commented Nov 1, 2024

Fixed tox and re-filled to make sure none of my suggestions broke anything. Will merge as soon as the CI passes.

@marioevz marioevz merged commit cfbfea9 into ethereum:main Nov 1, 2024
3 checks passed
@marioevz marioevz deleted the rjumpi-over-retf branch November 1, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants