-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(tests): EOF - EIP-4200 EIP-6206 RJUMPI with JUMPF #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shemnon
reviewed
Oct 30, 2024
tests/osaka/eip7692_eof_v1/eip5450_stack/test_code_validation.py
Outdated
Show resolved
Hide resolved
pdobacz
commented
Oct 31, 2024
shemnon
approved these changes
Oct 31, 2024
marioevz
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
tests/osaka/eip7692_eof_v1/eip5450_stack/test_code_validation.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7692_eof_v1/eip5450_stack/test_code_validation.py
Outdated
Show resolved
Hide resolved
Fixed tox and re-filled to make sure none of my suggestions broke anything. Will merge as soon as the CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ποΈ Description
Continues #833 with some tests with JUMPF to non-returning functions. I got stuck on JUMPF to returning functions so I'm making this little step first.
π Related Issues
na
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.