Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): print fill output in coverage workflow on errors #919

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix(ci): print fill output in coverage workflow on errors #919

merged 1 commit into from
Oct 28, 2024

Conversation

winsvega
Copy link
Contributor

@winsvega winsvega commented Oct 28, 2024 •
edited
Loading

🗒️ Description

print log on fill errors

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@winsvega winsvega requested a review from marioevz October 28, 2024 11:53
danceratopz
danceratopz approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danceratopz danceratopz merged commit 0f56ad4 into main Oct 28, 2024
4 of 5 checks passed
@danceratopz danceratopz deleted the coveragefix branch October 28, 2024 12:36
@danceratopz danceratopz changed the title fix coverage log on errors fix(ci): print fill output in coverage workflow on errors Oct 28, 2024
@danceratopz danceratopz added type:bug Something isn't working scope:ci Scope: Continuous Integration labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danceratopz danceratopz danceratopz approved these changes

@marioevz marioevz Awaiting requested review from marioevz

Assignees
No one assigned
Labels
scope:ci Scope: Continuous Integration type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winsvega @danceratopz