Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): fix/add test github actions locally page #909

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix(docs): fix/add test github actions locally page #909

merged 1 commit into from
Oct 23, 2024

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Oct 23, 2024 •
edited
Loading

🗒️ Description

@winsvega tested the docs. This PR deals with the feedback from #904.

🔗 Related Issues

Resolves #904

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md. Skipped
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added type:bug Something isn't working scope:docs Scope: Documentation labels Oct 23, 2024
@danceratopz danceratopz requested a review from winsvega October 23, 2024 05:55
@danceratopz danceratopz merged commit 5a31516 into main Oct 23, 2024
3 of 5 checks passed
@danceratopz danceratopz deleted the docs/fix/running-actions-locally branch October 23, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winsvega winsvega winsvega approved these changes

Assignees
No one assigned
Labels
scope:docs Scope: Documentation type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

running github actions locally docs
2 participants
@danceratopz @winsvega