-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(tests): EOF - EIP-4750: unreachable code sections #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7b6daf
to
8750cb2
Compare
chfast
added a commit
to ipsilon/tests
that referenced
this pull request
Oct 1, 2024
pdobacz
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments, lgtm!
tests/prague/eip7692_eof_v1/eip4750_functions/test_code_validation.py
Outdated
Show resolved
Hide resolved
This migrates tests for unreachable code sections from EOFTests/efValidation/unreachable_code_sections_.json but also complements test cases with focus on containers where each section is referenced by some section but some are not reachable from section 0.
8750cb2
to
e85d731
Compare
marioevz
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, it's also fine by me if it stays in this single file, thanks!
winsvega
pushed a commit
to ethereum/tests
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope:tests
Scope: Changes EL client test cases in `./tests`
type:test
Type: Add/refactor fw unit tests; no fw or el client test case changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This migrates tests for unreachable code sections from
EOFTests/efValidation/unreachable_code_sections_.json
but also complements test cases with focus on containers where
each section is referenced by some section but some are not reachable
from section 0.
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.