Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs,filler): add info about ripemd160 & update running actions locally #847

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Sep 30, 2024

🗒️ Description

Docs:

  • Improve "Running Github Actions Locally" developer docs section.
  • Add RIPEMD160 precompile problem to "Installation Troubleshooting".
  • Also snuck in: Improve tox commands in "Verifying Changes" (tox -> uvx --with=tox-uv tox).

Filler:

  • Set interpolation to None in configparser.ConfigParser(interpolation=None) to avoid issues parsing the GITHUB_REF in when workflows are ran with nektos/act.

🔗 Related Issues

#792

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md. Skipped
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added scope:docs Scope: Documentation type:feat type: Feature labels Sep 30, 2024
@danceratopz danceratopz marked this pull request as ready for review September 30, 2024 21:16
@winsvega
Copy link
Contributor

winsvega commented Oct 1, 2024

Need to fix line 517 in filler.py plugin

@winsvega winsvega self-requested a review October 2, 2024 07:54
@danceratopz danceratopz changed the title feat(docs): add info about ripemd160 & update github actions feat(docs,filler): add info about ripemd160 & update github actions Oct 2, 2024
@danceratopz danceratopz added the scope:fw Scope: Framework (evm|tools|forks|pytest) label Oct 2, 2024
@danceratopz
Copy link
Member Author

Thanks for adding the ConfigParser fix, @winsvega

@danceratopz danceratopz merged commit 96efd73 into main Oct 2, 2024
5 checks passed
@danceratopz danceratopz deleted the docs/update-github-actions branch October 2, 2024 09:29
@danceratopz danceratopz changed the title feat(docs,filler): add info about ripemd160 & update github actions feat(docs,filler): add info about ripemd160 & update running actions locally Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:docs Scope: Documentation scope:fw Scope: Framework (evm|tools|forks|pytest) type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants