refactor(tests): unify EOF return code constants #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdobacz
approved these changes
Sep 25, 2024
danceratopz
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Nice clean-up, really helps readability. Just one very pedantic naming nit below, please see if you agree.
It would be nice to make these values available in our framework libraries and use them consistently in all tests - I made a separate issue for that to not block this PR, cf #835.
8 tasks
chfast
approved these changes
Sep 25, 2024
38d85eb to
66565b9
Compare
For EOF create and EXTCALL tests use the same return code constants for success, failure, and revert values. Signed-off-by: Danno Ferrin <danno@numisight.com>
66565b9 to
5420cf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
For EOF create and EXTCALL tests use the same return code constants for
success, failure, and revert values.
🔗 Related Issues
✅ Checklist
All: Added an entry to CHANGELOG.md.skippedmkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.