-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(tests): EOF - EIP-7620: Dangling data in subcontainer test #812
Conversation
Test dangling data inside a subcontainer Signed-off-by: Danno Ferrin <danno@numisight.com>
Covers this fuzzing find - ipsilon/eof#146 (comment) |
tests/prague/eip7692_eof_v1/eip7620_eof_create/test_subcontainer_validation.py
Show resolved
Hide resolved
Signed-off-by: Danno Ferrin <danno@numisight.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked if geth is failing these tests? I believe it only should fail the initcode variant.
tests/prague/eip7692_eof_v1/eip7620_eof_create/test_subcontainer_validation.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Danno Ferrin <danno@numisight.com>
Interestingly, geth only fails the (corrected) initcode form of the test, and correctly marks the runtime mode of the test as invalid. |
This agrees with the fuzzer. I believe this is because it passes "initcode" mode to subcontainer validation and maybe this incorrectly allows additional bytes (as in create transaction). |
Here's the fix, explains the initcode only failure - MariusVanDerWijden/go-ethereum@4392a1c I haven't dug in deeply but I concur with the handling hypothesis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: Danno Ferrin danno@numisight.com
ποΈ Description
Test dangling data inside a subcontainer
π Related Issues
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.