Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests): EOF: tests for invalid non-returning sections #794

Merged
merged 1 commit into from
Sep 11, 2024
Merged

new(tests): EOF: tests for invalid non-returning sections #794

merged 1 commit into from
Sep 11, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 9, 2024 •
edited by danceratopz
Loading

🗒️ Description

Add new EOF validation tests where the a section marked returning/non-returning does not match the reality.

🔗 Related Issues

ipsilon/eof#146

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast chfast requested a review from gumb0 September 9, 2024 09:23
@chfast chfast added scope:tests Scope: Changes EL client test cases in `./tests` type:test Type: Add/refactor fw unit tests; no fw or el client test case changes labels Sep 9, 2024
@chfast chfast mentioned this pull request Sep 9, 2024
Closed
@chfast chfast force-pushed the eof/non_returning branch 3 times, most recently from bd7ea51 to eef1ce6 Compare September 9, 2024 10:14
marioevz
marioevz reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, thanks.

@chfast
new(tests): EOF: tests for invalid non-returning sections
61f133f 
Add new EOF validation tests where the a section marked
returning/non-returning does not match the reality.
marioevz
marioevz approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@chfast chfast removed the request for review from gumb0 September 11, 2024 11:01
@danceratopz danceratopz merged commit 4b46f12 into ethereum:main Sep 11, 2024
4 checks passed
@danceratopz danceratopz deleted the eof/non_returning branch September 11, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danceratopz danceratopz danceratopz left review comments

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
scope:tests Scope: Changes EL client test cases in `./tests` type:test Type: Add/refactor fw unit tests; no fw or el client test case changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chfast @marioevz @danceratopz