Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs/tests): EOF: Update tracker, add unimplemented tests #773

Merged
merged 5 commits into from
Sep 2, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Aug 28, 2024

🗒️ Description

Updates the EOF tracker to mark all implemented tests (and implement missing ones).

The only section covered so far by this PR is EIP-3540/Validation.

File tests/prague/eip7692_eof_v1/eip3540_eof_v1/container.py has also been deleted and all test cases are now incorporated into tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_container_validation.py

@winsvega I think no coverage should be lost for this PR and actually it should increase.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz requested review from shemnon, gumb0 and winsvega August 28, 2024 23:01
@winsvega
Copy link
Contributor

I thought just know if you hesitate to enable coverage check on each pr, lets keep it optional. So you need touch coverage file to trigger it

@winsvega winsvega mentioned this pull request Aug 29, 2024
8 tasks
@winsvega
Copy link
Contributor

Here is the coverage run, using new coverage script:
#774

@marioevz marioevz force-pushed the update-eof-tracker branch from f91eb27 to 90490f1 Compare August 30, 2024 17:25
@marioevz marioevz added scope:tests Scope: Changes EL client test cases in `./tests` scope:docs Scope: Documentation type:feat type: Feature labels Aug 30, 2024
@marioevz
Copy link
Member Author

@pdobacz @shemnon I think this is good to go, could you approve if you think this is ok? thanks.

@marioevz marioevz merged commit 3fc3792 into main Sep 2, 2024
7 checks passed
@marioevz marioevz deleted the update-eof-tracker branch September 2, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:docs Scope: Documentation scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants