new(tests): EOF: Validate EOF only opcodes are invalid in legacy #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap the baseline and subject in EOF container code. Signed-off-by: Danno Ferrin <danno@numisight.com>
Test a code block containing the new EOF opcodes and checks they fail before they complete. Signed-off-by: Danno Ferrin <danno@numisight.com>
marioevz
reviewed
Aug 27, 2024
tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_opcodes_in_legacy.py
Outdated
Show resolved
Hide resolved
tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_opcodes_in_legacy.py
Outdated
Show resolved
Hide resolved
rakita
added a commit
to rakita/eof
that referenced
this pull request
Sep 4, 2024
EEST, have run slightly newer test suite from this PR: ethereum/execution-spec-tests#768 ethereum/tests are run on every Revm PR: statetests: https://github.com/bluealloy/revm/blob/89b65e1e4b5bbb2ddba4f414ca41ce3f8ad9758d/.github/workflows/ethereum-tests.yml#L51 EOF validation: https://github.com/bluealloy/revm/blob/89b65e1e4b5bbb2ddba4f414ca41ce3f8ad9758d/.github/workflows/ethereum-tests.yml#L58
…eof/legacy-opcodes
Signed-off-by: Danno Ferrin <danno@numisight.com>
marioevz
approved these changes
Sep 5, 2024
tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_opcodes_in_legacy.py
Outdated
Show resolved
Hide resolved
tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_opcodes_in_legacy.py
Outdated
Show resolved
Hide resolved
tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_opcodes_in_legacy.py
Outdated
Show resolved
Hide resolved
tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_opcodes_in_legacy.py
Outdated
Show resolved
Hide resolved
tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_opcodes_in_legacy.py
Outdated
Show resolved
Hide resolved
tests/prague/eip7692_eof_v1/eip3540_eof_v1/test_opcodes_in_legacy.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
EOF EXTCALL gas tests were broken, calling EXTCALL in legacy mode.
To address this new tests are added to validate all EOF only opcodes fail when executed in a legacy contract.
🔗 Related Issues
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.