Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF - EIP-3540: Test types with 128 inputs #749

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

gurukamath
Copy link
Contributor

πŸ—’οΈ Description

Upstreaming tests from specs implementation. Test 1 - 128 inputs in section 2.

πŸ”— Related Issues

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a slight variation of single_code_section_input_too_large in tests/prague/eip7692_eof_v1/eip3540_eof_v1/container.py, difference being that in this case the section is non-returning because of the STOP.

I think we could simply move this test to tests/prague/eip7692_eof_v1/eip3540_eof_v1/container.py below the single_code_section_input_too_large, and modify the code_outputs to be NON_RETURNING_SECTION.

@gurukamath gurukamath force-pushed the upstream-from-specs branch from 332c0ac to c415560 Compare August 21, 2024 08:03
@gurukamath
Copy link
Contributor Author

This seems like a slight variation of single_code_section_input_too_large in tests/prague/eip7692_eof_v1/eip3540_eof_v1/container.py, difference being that in this case the section is non-returning because of the STOP.

I think we could simply move this test to tests/prague/eip7692_eof_v1/eip3540_eof_v1/container.py below the single_code_section_input_too_large, and modify the code_outputs to be NON_RETURNING_SECTION.

Updated

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marioevz marioevz changed the title Test types with 128 inputs new(tests): EOF - EIP-3540: Test types with 128 inputs Aug 22, 2024
@marioevz marioevz merged commit e35feea into ethereum:main Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants