Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fw): add optional Container.expected_bytecode #737

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Aug 9, 2024

🗒️ Description

Add optional Container.expected_bytecode with raw bytes of the expected constructed bytecode.
This allows confirming that raw EOF and Container() representations are identical.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Add optional `Container.expected_bytecode` with raw bytes
of the expected constructed bytecode.
This allows confirming that raw EOF and `Container()` representations
are identical.
@chfast chfast requested review from marioevz and winsvega August 9, 2024 23:10
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit e6dac62 into ethereum:main Aug 10, 2024
4 checks passed
@marioevz marioevz deleted the eof/container_expected_bytecode branch August 10, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants