Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consume): add reproducible consume/hive commands #717

Merged
merged 11 commits into from
Aug 12, 2024

Conversation

spencer-tb
Copy link
Collaborator

@spencer-tb spencer-tb commented Jul 26, 2024

🗒️ Description

Adds the consume and hive commands to re-run a test case within hiveview. This is to aid test case reproduction for client devs incase of a failure.

Requires a small change to app-suite.js within hive: ethereum/hive@cdbd336
You can test using this branch: https://github.com/spencer-tb/hive/tree/prague/devnet-1

Gives us the following on hiveview:
Screenshot 2024-07-27 at 18 52 03

🔗 Related Issues

N/A

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@spencer-tb spencer-tb added type:feat type: Feature scope:consume Scope: Consume command suite labels Jul 26, 2024
@spencer-tb spencer-tb force-pushed the consume-hive-command branch from d528e9a to fc4048c Compare July 27, 2024 17:17
@spencer-tb spencer-tb changed the title feat(consume): add reproduce-able hive command feat(consume): add reproducible hive command Jul 27, 2024
@spencer-tb spencer-tb force-pushed the consume-hive-command branch from fc4048c to 2fe804c Compare July 27, 2024 17:38
@spencer-tb spencer-tb changed the title feat(consume): add reproducible hive command feat(consume): add reproducible consume/hive commands Jul 27, 2024
@spencer-tb spencer-tb force-pushed the consume-hive-command branch from 2fe804c to 4a89320 Compare July 27, 2024 17:46
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, some comments.

@spencer-tb spencer-tb force-pushed the consume-hive-command branch 3 times, most recently from 41a10bb to 89f675f Compare July 31, 2024 19:04
@spencer-tb spencer-tb force-pushed the consume-hive-command branch from 7710dea to 44a3434 Compare July 31, 2024 20:05
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks! Just one comment.

@marioevz marioevz merged commit 9ecd0cf into ethereum:main Aug 12, 2024
4 checks passed
@danceratopz
Copy link
Member

Nice addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:consume Scope: Consume command suite type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants