chore(consume): fix --input
when running from hive
#701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR allows us to run consume commands using the following Dockerfile entrypoint from hive:
Problem
The condition
if not sys.stdin.isatty():
checks if the standard input (stdin) is connected to a terminal. If it's not connected to a terminal, it implies that the input might be coming from a pipe or a file, which is why the command adds --input=stdin.In a Docker container,
sys.stdin.isatty()
returns False because Docker doesn't provide a terminal interface by default. This causes an issue where the input is incorrectly automatically set to stdin when running in Docker.Solution
To fix the latter we additionally check for
--input
within the consume command arguements. We do not supply this when piping.🔗 Related Issues
N/A
✅ Checklist