-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pytest): directly create properties file and release tarball from fill #627
feat(pytest): directly create properties file and release tarball from fill #627
Conversation
Tested with this Github Actions Workflow: https://github.com/danceratopz/execution-spec-tests/actions/runs/9500351128/job/26183213458 Example artifact ("stable"): https://github.com/danceratopz/execution-spec-tests/actions/runs/9500351128/artifacts/1598139447
|
Renamed the "properties" file from This file is mainly intended for internal EEST use ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks!
@marioevz I've noticed that this might have changed the layout of the release artifact - inside the Unless I've misconfigured sth on my end, you can take a look at such release here - |
@pdobacz I think you're right, let me dig into the changes and see how we can fix it, thanks for pointing this out! |
…m fill (#627) * feat(fill): enable release tarball creation directly from fill * feat(fill): write a properties file to the output dir * feat(ci): use fill's properties and tar.gz features in ci * refactor(fw): use std lib's configparser for properties file * tests(fw): add test for fill's property file * feat(fill): write pytest-metadata props to fixtures.properties * docs: update changelog * docs: update fill --help output * chore(fill): improve docstring readability * chore(fill): improve docstring readability * fix(fill): use .ini instead of .properties for build props file * docs: update due to renaming .properties -> .ini * chore: update whitelist * fix(fill): add ci to environment section in fixtures.ini
🗒️ Description
Adds some release-specific requirements directly to
fill
command:If
--output=fixtures.tgz
is specified, then additionally create the tarball. From the help:Always writes a fixtures build properties file
fixtures.ini
to the output directory. A build name may be specified via--build-name
:Uses 1. and 2. in
.github/actions/build-fixtures/action.yaml
.Example fixture build properties file (
--build-name=eip7692
):🔗 Related Issues
None
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.