Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fw,tests): Withdrawal request v1 update execution-apis #549 #600

Merged
merged 3 commits into from
Jun 25, 2024
Merged

fix(fw,tests): Withdrawal request v1 update execution-apis #549 #600

merged 3 commits into from
Jun 25, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jun 6, 2024 •
edited
Loading

🗒️ Description

Update tests and framework to match changes described in ethereum/execution-apis#549

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Base automatically changed from fixture-pre to main June 12, 2024 17:54
@marioevz marioevz force-pushed the withdrawal-request-v1-update-pr-549 branch from 5adfd14 to e1dc20f Compare June 21, 2024 17:34
@marioevz marioevz marked this pull request as ready for review June 21, 2024 17:37
@marioevz marioevz added scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore type:refactor Type: Refactor scope:fw Scope: Framework (evm|tools|forks|pytest) labels Jun 21, 2024
@marioevz marioevz requested a review from winsvega June 21, 2024 17:37
spencer-tb
spencer-tb approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marioevz marioevz force-pushed the withdrawal-request-v1-update-pr-549 branch from e1dc20f to e119c13 Compare June 25, 2024 18:58
@marioevz marioevz merged commit 60e5eb4 into main Jun 25, 2024
7 checks passed
@marioevz marioevz deleted the withdrawal-request-v1-update-pr-549 branch June 25, 2024 19:15
spencer-tb pushed a commit that referenced this pull request Jun 26, 2024
@marioevz @spencer-tb
fix(fw,tests): Withdrawal request v1 update execution-apis #549 (#600)
3e79581 
* fix(fw): Rename validator_public_key -> validator_pubkey

* fix(tests): EIP-7002: Rename validator_public_key -> validator_pubkey

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-tb spencer-tb spencer-tb approved these changes

@winsvega winsvega Awaiting requested review from winsvega

Assignees
No one assigned
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore type:refactor Type: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marioevz @spencer-tb