Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forks: Implement fork operators, remove is_fork #367

Merged
merged 2 commits into from
Dec 21, 2023
Merged

forks: Implement fork operators, remove is_fork #367

merged 2 commits into from
Dec 21, 2023

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Dec 21, 2023 •
edited
Loading

🗒️ Description

Implements the following operators for the fork objects:

  • Greater than (>): Fork is newer than other fork
  • Greater than or equal to (>=): Fork is at least as newer than other fork
  • Less than (<): Fork is older than other fork
  • Less than or equal to (<=): Fork is at least as old than other fork

is_fork is now removed.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:forks Scope: Changes ethereum_test_forks package scope:tests Scope: Changes EL client test cases in `./tests` labels Dec 21, 2023
spencer-tb
spencer-tb approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10 - LGTM!

@marioevz marioevz changed the title ethereum_test_forks: Implement fork operators, remove is_fork forks: Implement fork operators, remove is_fork Dec 21, 2023
@marioevz marioevz merged commit 19a02ec into ethereum:main Dec 21, 2023
@marioevz marioevz deleted the fork-operators branch December 21, 2023 19:10
@danceratopz
Copy link
Member

Very nice 😄

@holgerd77
Copy link

Oh, that’s a nice PR! 🙂👍

@marioevz marioevz mentioned this pull request Jan 5, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-tb spencer-tb spencer-tb approved these changes

@danceratopz danceratopz Awaiting requested review from danceratopz

Assignees
No one assigned
Labels
scope:forks Scope: Changes ethereum_test_forks package scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marioevz @danceratopz @holgerd77 @spencer-tb