chore(tests): update bls12 test vectors #1289
Merged
+3,590
−235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
d65a8a6 to
4fd38f4
Compare
danceratopz
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
LVGTM.
Confirmed that this catches Nethermind's fail before the fix:
- FAIL (as expected) 🥳 with 1.32.0-unstable+146a645be192fbe733e19005c8d9943855021368/, this is the last commit before BLS fix: don't return 1 because of infinity point NethermindEth/nethermind#8277 was merged.
- PASS 🥳 with 1.32.0-unstable+29cccb1fc1028d3efcdf04edfbb91e85f217c932
|
Also confirmed that the new tests fail without evmone's recent fix:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Following: #1275, this PR adds the updated test vectors to consolidate coverage for the BLS12 consensus bug.
From 1098 test cases to now 2073. There are still more we can add with parameterization.
Tested against geth using consume direct.
🔗 Related Issues
✅ Checklist