Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): improve tests for EOF prefix #1187

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

chfast
Copy link
Member

@chfast chfast commented Feb 6, 2025

πŸ—’οΈ Description

Improve tests for EOF magic and version bytes in the EOF prefix by omitting parameters of valid values. Also add some new parameter values suggested by ethereum/tests.

πŸ”— Related Issues

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt. delete converted EOF prefix testsΒ tests#1450
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Improve tests for EOF magic and version bytes in the EOF prefix
by omitting parameters of valid values. Also add some new parameter
values suggested by ethereum/tests.
@chfast chfast added the scope:tests Scope: Changes EL client test cases in `./tests` label Feb 6, 2025
@chfast chfast requested review from winsvega and hugo-dc February 6, 2025 12:33
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

I'm not sure why we had parametrized the version to the valid value in the first place, but glad it's fixed now πŸ‘

@marioevz marioevz merged commit 08e854b into ethereum:main Feb 7, 2025
11 checks passed
@marioevz marioevz deleted the eof/prefix branch February 7, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants