Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tooling): update execution-specs version to 99238233 #1181

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Feb 5, 2025

Requires #1180

🗒️ Description

Bumps the version of execution-spec used by:

  1. EEST libraries (uv.lock, pyproject.toml), and,
  2. EEST test fixture generation (eels_resolutions.json, tox_verify.yaml)

to ethereum/execution-specs@9923823.

Note, the version is intentionally added to pyproject.toml to pin ethereum when used with ediable, interactive use (uvx --with-editable . ipython).

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.

@danceratopz danceratopz added scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore scope:fw Scope: Framework (evm|tools|forks|pytest) scope:deps Scope: Updates package dependencies labels Feb 5, 2025
@danceratopz
Copy link
Member Author

I verified all tests (until and including Cancun) with hasher. No changes in test fixtures with these changes 🥳

(I do get sporadic fails for the tests/cancun/eip1153_tstore/test_tstorage.py::test_run_until_out_of_gas tests due to timeouts, but these are unrelated.).

@marioevz marioevz force-pushed the chore/tooling/update-execution-specs branch from 209465c to bad11d9 Compare February 5, 2025 17:00
@marioevz
Copy link
Member

marioevz commented Feb 5, 2025

I've rebased to main, there were no conflicts so I can wait until the CI finishes and then merge.

@marioevz marioevz marked this pull request as ready for review February 5, 2025 17:01
@danceratopz danceratopz force-pushed the chore/tooling/update-execution-specs branch from bad11d9 to 7ceb2eb Compare February 5, 2025 17:01
@danceratopz
Copy link
Member Author

I've rebased to main, there were no conflicts so I can wait until the CI finishes and then merge.

Oops me too.

@danceratopz danceratopz requested a review from marioevz February 5, 2025 17:03
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked the fixtures produced and they are identical. Thanks!

@marioevz marioevz merged commit 016bc4d into main Feb 5, 2025
21 checks passed
@marioevz marioevz deleted the chore/tooling/update-execution-specs branch February 5, 2025 17:22
@marioevz marioevz mentioned this pull request Feb 5, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:deps Scope: Updates package dependencies scope:fw Scope: Framework (evm|tools|forks|pytest) scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants