Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(execute): fix selected forks incompatibility #1157

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jan 29, 2025

🗒️ Description

Fixes an issue when using uv run execute where now the config.selected_forks variable that is prepared by the forks plugin also contains the transition forks, which resulted in the execute command always failing to start.

🔗 Related Issues

Bug introduced in fork plugin refactor in:

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added type:bug Something isn't working scope:tools Scope: Changes ethereum_test_tools package labels Jan 29, 2025
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danceratopz danceratopz changed the title fix(plugins/execute): Fix selected forks incompatibility fix(execute): fix selected forks incompatibility Jan 29, 2025
@danceratopz danceratopz added scope:execute Scope: Changes to the execute command and removed scope:tools Scope: Changes ethereum_test_tools package labels Jan 29, 2025
@marioevz marioevz merged commit b6c0635 into main Jan 29, 2025
21 checks passed
@marioevz marioevz deleted the fix-execute-fork-issue branch January 29, 2025 21:14
marioevz added a commit to marioevz/execution-spec-tests that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:execute Scope: Changes to the execute command type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants