Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(t8n,filler): Append EELS resolution information to _info for generate test jsons #1123

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

fselmo
Copy link
Contributor

@fselmo fselmo commented Jan 24, 2025

🗒️ Description

This PR consumes the metadata passed on from the ethereum-spec-evm-resolver and appends this information to the _info section in generated test jsons.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@fselmo fselmo force-pushed the test-info-metadata branch 2 times, most recently from 79f7073 to e42b849 Compare January 24, 2025 17:58
@fselmo fselmo self-assigned this Jan 27, 2025
@fselmo fselmo force-pushed the test-info-metadata branch from e42b849 to d46993b Compare January 27, 2025 18:24
@fselmo fselmo added the scope:evm Scope: evm_transition_tool package label Jan 27, 2025
@fselmo fselmo force-pushed the test-info-metadata branch 2 times, most recently from 0732ded to 59f8131 Compare January 27, 2025 18:41
@fselmo fselmo added the type:feat type: Feature label Jan 27, 2025
- Look for ``info_metadata`` in the transition tool POST request response
  and use this field to extend the ``_info`` field in the generated
  test json.
@fselmo fselmo force-pushed the test-info-metadata branch from 59f8131 to e2cbb61 Compare January 27, 2025 18:44
@fselmo fselmo marked this pull request as ready for review January 27, 2025 18:46
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks so much for this!

@marioevz marioevz changed the title Append EELS resolution information to _info for generate test jsons feat(t8n,filler): Append EELS resolution information to _info for generate test jsons Jan 28, 2025
@marioevz marioevz merged commit b16de8d into ethereum:main Jan 28, 2025
11 checks passed
@fselmo fselmo deleted the test-info-metadata branch January 28, 2025 23:13
marioevz pushed a commit to marioevz/execution-spec-tests that referenced this pull request Jan 30, 2025
…erate test jsons (ethereum#1123)

- Look for ``info_metadata`` in the transition tool POST request response
  and use this field to extend the ``_info`` field in the generated
  test json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:evm Scope: evm_transition_tool package type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants