Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fw): fix Address padding options #1113

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

chfast
Copy link
Member

@chfast chfast commented Jan 23, 2025

πŸ—’οΈ Description

Pass all aguments to Address() to the super constructor. This fixes ability to create addresses out of shorter bytes, e.g. Address(my_bytes, left_padding=True).

πŸ”— Related Issues

Solves an issue introduced by #1010.

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • [ ] All: Added an entry to CHANGELOG.md. skipped

Pass all aguments to Address() to the super constructor.
This fixes ability to create addresses out of shorter bytes,
e.g. `Address(my_bytes, left_padding=True)`.
@chfast chfast force-pushed the fix_address_padding branch from 3880102 to f29a8d6 Compare January 23, 2025 14:16
@chfast chfast added scope:fw Scope: Framework (evm|tools|forks|pytest) type:bug Something isn't working labels Jan 23, 2025
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @chfast, especially for the test!

@danceratopz danceratopz merged commit 4891ac7 into ethereum:main Jan 23, 2025
11 checks passed
@danceratopz danceratopz deleted the fix_address_padding branch January 23, 2025 14:56
@danceratopz danceratopz changed the title fix(fw): fix Address padding options fix(fw): fix Address padding options Jan 23, 2025
fselmo pushed a commit to fselmo/execution-spec-tests that referenced this pull request Jan 24, 2025
Co-authored-by: danceratopz <danceratopz@gmail.com>
codeofcarson pushed a commit to codeofcarson/execution-spec-tests that referenced this pull request Jan 24, 2025
Co-authored-by: danceratopz <danceratopz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants