Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests): tests for JUMPF invalid section index #1112

Merged
merged 1 commit into from
Jan 23, 2025
Merged

new(tests): tests for JUMPF invalid section index #1112

merged 1 commit into from
Jan 23, 2025

Conversation

chfast
Copy link
Member

@chfast chfast commented Jan 23, 2025

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast chfast added the scope:tests Scope: Changes EL client test cases in `./tests` label Jan 23, 2025
@chfast chfast requested review from pdobacz and Copilot January 23, 2025 12:05
Copilot
Copilot AI reviewed Jan 23, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
@chfast chfast merged commit b792235 into ethereum:main Jan 23, 2025
11 checks passed
@chfast chfast deleted the jumpf_invalid_code_section branch January 23, 2025 13:13
@chfast chfast mentioned this pull request Jan 24, 2025
Merged
fselmo pushed a commit to fselmo/execution-spec-tests that referenced this pull request Jan 24, 2025
@chfast @fselmo
new(tests): tests for JUMPF invalid section index (ethereum#1112)
0d677ed
codeofcarson pushed a commit to codeofcarson/execution-spec-tests that referenced this pull request Jan 24, 2025
@chfast @codeofcarson
new(tests): tests for JUMPF invalid section index (ethereum#1112)
e18eeee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@pdobacz pdobacz pdobacz approved these changes

Assignees
No one assigned
Labels
scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfast @pdobacz