Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests): extend tests for CALLF invalid section index #1111

Merged
merged 1 commit into from
Jan 23, 2025
Merged

new(tests): extend tests for CALLF invalid section index #1111

merged 1 commit into from
Jan 23, 2025

Conversation

chfast
Copy link
Member

@chfast chfast commented Jan 23, 2025 •
edited
Loading

🗒️ Description

It takes a single test case for CALLF's invalid code section index to separate more specific test and add 2 more cases (one from ethereum/tests).

The same test case are going to be done later for JUMPF.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast chfast added scope:tests Scope: Changes EL client test cases in `./tests` type:test Type: Add/refactor fw unit tests; no fw or el client test case changes labels Jan 23, 2025
@chfast chfast requested review from pdobacz and gumb0 January 23, 2025 10:33
@chfast chfast force-pushed the callf_invalid_code_section_index branch from 351d24f to 3e1a339 Compare January 23, 2025 11:52
@chfast chfast merged commit 1cffb43 into ethereum:main Jan 23, 2025
11 checks passed
@chfast chfast deleted the callf_invalid_code_section_index branch January 23, 2025 12:00
@chfast chfast mentioned this pull request Jan 24, 2025
Merged
fselmo pushed a commit to fselmo/execution-spec-tests that referenced this pull request Jan 24, 2025
@chfast @fselmo
new(tests): extend tests for CALLF invalid section index (ethereum#1111)
0ba5f60 
It takes a single test case for `CALLF`'s invalid code section index to separate more specific test and add 2 more cases (one from ethereum/tests).
codeofcarson pushed a commit to codeofcarson/execution-spec-tests that referenced this pull request Jan 24, 2025
@chfast @codeofcarson
new(tests): extend tests for CALLF invalid section index (ethereum#1111)
b103a1b 
It takes a single test case for `CALLF`'s invalid code section index to separate more specific test and add 2 more cases (one from ethereum/tests).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdobacz pdobacz pdobacz approved these changes

@gumb0 gumb0 Awaiting requested review from gumb0

Assignees
No one assigned
Labels
scope:tests Scope: Changes EL client test cases in `./tests` type:test Type: Add/refactor fw unit tests; no fw or el client test case changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfast @pdobacz