-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fixtures): Add state
field to post in state tests
#1064
Conversation
Amazing, thanks! 😊 👍 |
Why postDecoded. There was a field postState already. We just removed it because there were too many tx and tests. So the idea was if you have a mismatch, you run test fill command with a flag that exports the post state. But if we don't care about the size, we just restore the postState field. it was called decoded in blockchain tests because header and data decoded from given rlp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep original namepostState
or 'state' since it is already in post dictionary
postDecoded
field to state testsstate
field to post in state tests
@winsvega applied the suggestion and the field is now named @jochem-brouwer just a heads-up that the field was renamed. |
* feat(fixtures): Add `postDecoded` field to state tests * rename field to `state`
🗒️ Description
Adds a
state
field to each network post result that contains the resulting allocation of the transaction execution.This is meant to be a debugging aid in case there is a state root mismatch when consuming the tests.
@jochem-brouwer
🔗 Related Issues
None
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.