add additionalProperties: false to objects

[anukul]

Closes #63

[anukul]

Seeing a speccheck failure for get-block-by-hash response after this - https://www.jsonschemavalidator.net/s/60jyjLPr

Can discuss specific failures here if the test workflow can be approved please

[lightclient]

Hey @anukul thanks for working on this! Would love to see this merged. The issue is a bit deceiving though I think, because the task is a bit more difficult than simply marking every method additionalProperties: false.

When this is marked on the schema and additional values are disallowed, many test values stop validating against the spec. You can see in the CI result for speccheck. The output could use some work, but last two lines are the important ones. The last line is the json value that failed validation and the second to last line is the schema it failed to validate against.

Here is what it is currently failing on: https://www.jsonschemavalidator.net/s/VPmC37j8

It appears to be an issue with how transactions are represented within blocks. There are extra fields like blockHash, blockNumber, etc. These fields are defined in TransactionInfo, but not SignedTransaction, which is what Block is currently using. I think it should be using TransactionInfo instead.

Hopefully this is helpful - let me know if you have any questions. The bulk of the work for resolving this issue will be working though the speccheck errors and updating the schema so that it matches exactly the test cases.

[anukul]

The issue is a bit deceiving though I think, because the task is a bit more difficult than simply marking every method additionalProperties: false.

Right, thanks a lot for reviewing.

After changing Block.transactions to TransactionInfo, I noticed that setting additionalProperties: false in a child schemas (c1, c2) causes certain types of composition to fail ({ oneOf: [c1, c2], properties: { ... } }

I took the approach of setting it everywhere and running speccheck + eyeballing for other such tricky instances.

Also attempted to fix two other reported errors:

• Missing property block.hash
• Missing property tx_receipt.type

[lightclient]

Looking good, just a few comments.

[lightclient]

Great work! Glad to finally close this issue.