-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for the Creator Contract #856
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## eof-create4 #856 +/- ##
===============================================
+ Coverage 98.28% 98.29% +0.01%
===============================================
Files 123 124 +1
Lines 14724 14854 +130
===============================================
+ Hits 14471 14601 +130
Misses 253 253
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: pdobacz <5735525+pdobacz@users.noreply.github.com>
Also support EOFCREATE and EOF with containers in bytecode helper. Co-authored-by: pdobacz <5735525+pdobacz@users.noreply.github.com>
Co-authored-by: pdobacz <5735525+pdobacz@users.noreply.github.com>
Co-authored-by: pdobacz <5735525+pdobacz@users.noreply.github.com>
Including support in state test runner and in export from state transition tests.
9b4d832
to
febfe66
Compare
Closing, as ipsilon/eof#78 just got merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Creator Contract is a hot topic rn, so here is a simple test of a manual, bytecode implementation I prepared. The implementation is as simple as possible, yet aligned with the pseudocode one from https://github.com/ipsilon/eof/blob/main/spec/eof.md#appendix-creator-contract
The bytecode implementation could be linked up from the megaspec if necessary, or copy-pasted into EIP-7620 - unless we decide to not have the Creator Contract in the end.