Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for the Creator Contract #856

Closed
wants to merge 19 commits into from
Closed

Add a test for the Creator Contract #856

wants to merge 19 commits into from

Conversation

pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Apr 5, 2024

The Creator Contract is a hot topic rn, so here is a simple test of a manual, bytecode implementation I prepared. The implementation is as simple as possible, yet aligned with the pseudocode one from https://github.com/ipsilon/eof/blob/main/spec/eof.md#appendix-creator-contract

The bytecode implementation could be linked up from the megaspec if necessary, or copy-pasted into EIP-7620 - unless we decide to not have the Creator Contract in the end.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (17c09c7) to head (0cf6c5b).

Additional details and impacted files
@@               Coverage Diff               @@
##           eof-create4     #856      +/-   ##
===============================================
+ Coverage        98.28%   98.29%   +0.01%     
===============================================
  Files              123      124       +1     
  Lines            14724    14854     +130     
===============================================
+ Hits             14471    14601     +130     
  Misses             253      253              
Flag Coverage Δ
statetests 59.55% <ø> (ø)
statetests-silkpre 19.34% <0.00%> (+0.18%) ⬆️
unittests 97.14% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...st/unittests/state_transition_eof_creator_test.cpp 100.00% <100.00%> (ø)

@pdobacz pdobacz marked this pull request as draft April 15, 2024 10:28
@gumb0 gumb0 force-pushed the eof-create4 branch 4 times, most recently from 9b4d832 to febfe66 Compare April 18, 2024 12:45
Base automatically changed from eof-create4 to master April 18, 2024 13:35
@pdobacz
Copy link
Contributor Author

pdobacz commented Apr 30, 2024

Closing, as ipsilon/eof#78 just got merged

@pdobacz pdobacz closed this Apr 30, 2024
@pdobacz pdobacz deleted the creator-test branch June 3, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants