Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add t8n features required by exe-spec-tests #604

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Conversation

rodiazet
Copy link
Contributor

No description provided.

@rodiazet rodiazet requested a review from chfast March 29, 2023 11:14
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #604 (3c96e41) into master (d0ef459) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #604   +/-   ##
=======================================
  Coverage   97.09%   97.09%           
=======================================
  Files          74       74           
  Lines        7395     7395           
=======================================
  Hits         7180     7180           
  Misses        215      215           
Flag Coverage Δ
blockchaintests 63.71% <ø> (ø)
statetests 63.11% <ø> (ø)
unittests 93.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

test/t8n/t8n.cpp Outdated Show resolved Hide resolved
test/t8n/t8n.cpp Outdated Show resolved Hide resolved
@rodiazet rodiazet requested a review from chfast March 29, 2023 12:26
@rodiazet rodiazet changed the title Add gasUsed field for block. Required by exe-spec-tests Add features required by exe-spec-tests Mar 29, 2023
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just let's merge #603 first.

test/t8n/t8n.cpp Outdated Show resolved Hide resolved
@rodiazet rodiazet force-pushed the t8n-improvements branch 3 times, most recently from a145d2e to 795bd2c Compare March 29, 2023 16:25
Required by exe-spec-tests. Also fixes "cumulativeGasUsed" for receipts.
@chfast chfast force-pushed the t8n-improvements branch from 795bd2c to 3c96e41 Compare March 29, 2023 16:32
@chfast chfast changed the title Add features required by exe-spec-tests Add t8n features required by exe-spec-tests Mar 29, 2023
@rodiazet rodiazet merged commit fd018f8 into master Mar 29, 2023
@rodiazet rodiazet deleted the t8n-improvements branch March 29, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants