trace: Print gas and gasUsed in hex #592
Conversation
021f51c to
c6996ad
Compare
|
Is this a requirement of the tracing format? |
425f64c to
d421915
Compare
No. I just want to have it similar to geth to avoid unnecessary problems when comparing tests results. |
|
Never mind, apparently it is in the tracing EIP:
|
| m_out << R"(,"gasUsed":)" << (ctx.start_gas - result.gas_left); | ||
| m_out << R"(,"gas":)" << std::hex << "0x" << result.gas_left; | ||
| m_out << R"(,"gasUsed":)" << std::hex << "0x" << (ctx.start_gas - result.gas_left) | ||
| << std::dec; | ||
| m_out << R"(,"output":")" << evmc::hex({result.output_data, result.output_size}) << '"'; |
There was a problem hiding this comment.
Apparently this field is not an even listed as optional in the EIP, @chfast.
There was a problem hiding this comment.
I can remove it and check once again if we have it implemented according to spec, but let's first confirm with @chfast
There was a problem hiding this comment.
It is useful for debugging. Let's keep it.
There was a problem hiding this comment.
@chfast Approve please if no other comments.
There was a problem hiding this comment.
Can one of you open a PR to the EIP adding output as an optional field? Not blocking this PR, just as an addition.
d421915 to
59540a1
Compare
No description provided.