cmake: Fix MRI script for evmone-standalone #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the command CREATE instead of OPEN in the evmone-standalone MRI script. The CREATE is better than OPEN because we don't want to reuse old libevmone-standalone.a just to create a new one from scratch. This also brings compatibility with llvm-ar which does not support OPEN command.
Codecov Report
@@ Coverage Diff @@
## release/0.8.0 #374 +/- ##
==============================================
Coverage 99.78% 99.78%
==============================================
Files 30 30
Lines 4153 4153
==============================================
Hits 4144 4144
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the command CREATE instead of OPEN in the evmone-standalone MRI
script. The CREATE is better than OPEN because we don't want to reuse
old libevmone-standalone.a just to create a new one from scratch.
This also brings compatibility with llvm-ar which does not support OPEN
command.
Fixes #373