Shortcut for 2^e #233
Closed
Shortcut for 2^e #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Jun 3, 2020
| auto exp_bytes = as_bytes(exponent); | ||
| uint8_t bit_to_set = exp_bytes[0]; | ||
| exp_bytes[0] = 0; | ||
| exp_bytes[bit_to_set >> 3] = uint8_t(uint8_t(1) << (bit_to_set & 7)); |
There was a problem hiding this comment.
Why not something like exponent = 2 << exponent; ?
@chfast would either of these solutions have a significant speed difference?
There was a problem hiding this comment.
Looks like at least in my benchmarks the 1 << exponent is the fastest (surprisingly). Full story in chfast/intx#146.
|
Yes, this makes sense, but I think I will move to the implementation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of contracts on the Ethereum mainnet that were compiled with Solidity prior to the shifting operations were available. For those, exponentiation 2^160 is used to emulate 1<<160. Measurements performed on turbo-geth confirm this. Since we are planning to integrate evmone into turbo-geth, and we have already implemented this shortcut (erigontech/erigon#505), it would be good to maintain that in evmone.
For #231